[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <23edfaea-fcee-4151-bfa8-d71d11a24401@t-8ch.de>
Date: Fri, 23 Feb 2024 14:16:15 +0100
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Luis Chamberlain <mcgrof@...nel.org>
Cc: Kees Cook <keescook@...omium.org>,
Joel Granados <j.granados@...sung.com>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH] sysctl: treewide: constify ctl_table_root::set_ownership
On 2023-12-28 05:22:56-0800, Luis Chamberlain wrote:
> On Tue, Dec 26, 2023 at 01:32:42PM +0100, Thomas Weißschuh wrote:
> > The set_ownership callback is not supposed to modify the ctl_table.
> > Enforce this expectation via the typesystem.
> >
> > The patch was created with the following coccinelle script:
> >
> > virtual patch
> > virtual context
> > virtual report
>
> If you remove this virtual stuff and mention how we verify manually
> through the build how users do not exits which rely on modifying the the
> table I thinkt these two patches are ready, thanks for doing this in
> Coccinelle it helps me review this faster!
Actually the 'table' parameter is never even used.
Do you prefer to drop it completely?
Thomas
Powered by blists - more mailing lists