netdev - Re: [PATCH] sysctl: treewide: constify ctl_table_root::set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zdi3HsFzG-p81CjG@bombadil.infradead.org>
Date: Fri, 23 Feb 2024 07:17:50 -0800
From: Luis Chamberlain <mcgrof@...nel.org>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Kees Cook <keescook@...omium.org>,
	Joel Granados <j.granados@...sung.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] sysctl: treewide: constify ctl_table_root::set_ownership

On Fri, Feb 23, 2024 at 02:16:15PM +0100, Thomas Weißschuh wrote:
> On 2023-12-28 05:22:56-0800, Luis Chamberlain wrote:
> > On Tue, Dec 26, 2023 at 01:32:42PM +0100, Thomas Weißschuh wrote:
> > > The set_ownership callback is not supposed to modify the ctl_table.
> > > Enforce this expectation via the typesystem.
> > > 
> > > The patch was created with the following coccinelle script:
> > > 
> > >   virtual patch
> > >   virtual context
> > >   virtual report
> > 
> > If you remove this virtual stuff and mention how we verify manually
> > through the build how users do not exits which rely on modifying the the
> > table I thinkt these two patches are ready, thanks for doing this in
> > Coccinelle it helps me review this faster!
> 
> Actually the 'table' parameter is never even used.

Oh wow.

> Do you prefer to drop it completely?

Absolutely.

  Luis