netdev - Re: [PATCH net-next] net: stmmac: fix typo in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240222191220.0507a4de@kernel.org>
Date: Thu, 22 Feb 2024 19:12:20 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Yanteng Si <siyanteng@...ngson.cn>
Cc: andrew@...n.ch, alexandre.torgue@...s.st.com, joabreu@...opsys.com,
 davem@...emloft.net, horms@...nel.org, fancer.lancer@...il.com,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: stmmac: fix typo in comment

On Wed, 21 Feb 2024 18:35:14 +0800 Yanteng Si wrote:
> This is just a trivial fix for a typo in a comment, no functional
> changes.
> 
> Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx")

Fixes is reserved for functional bugs, let's leave it out
for a typo correction.

> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
> index 358e7dcb6a9a..9d640ba5c323 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
> @@ -92,7 +92,7 @@
>  #define DMA_TBS_FTOV			BIT(0)
>  #define DMA_TBS_DEF_FTOS		(DMA_TBS_FTOS | DMA_TBS_FTOV)
>  
> -/* Following DMA defines are chanels oriented */
> +/* Following DMA defines are channels oriented */

I'm not a native speaker but I'd spell it "... are channel-oriented"
With a hyphen, channel not channels.

>  #define DMA_CHAN_BASE_ADDR		0x00001100
>  #define DMA_CHAN_BASE_OFFSET		0x80
>