netdev - Re: [PATCH net-next] net: stmmac: fix typo in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0aca3d8-3581-44c3-9b64-348b1572807e@loongson.cn>
Date: Wed, 28 Feb 2024 18:45:40 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Jakub Kicinski <kuba@...nel.org>
Cc: andrew@...n.ch, alexandre.torgue@...s.st.com, joabreu@...opsys.com,
 davem@...emloft.net, horms@...nel.org, fancer.lancer@...il.com,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: stmmac: fix typo in comment


在 2024/2/23 11:12, Jakub Kicinski 写道:
> On Wed, 21 Feb 2024 18:35:14 +0800 Yanteng Si wrote:
>> This is just a trivial fix for a typo in a comment, no functional
>> changes.
>>
>> Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx")
> Fixes is reserved for functional bugs, let's leave it out
> for a typo correction.

OK!

I will remove it.

Thanks,

Yanteng

>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
>> index 358e7dcb6a9a..9d640ba5c323 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
>> @@ -92,7 +92,7 @@
>>   #define DMA_TBS_FTOV			BIT(0)
>>   #define DMA_TBS_DEF_FTOS		(DMA_TBS_FTOS | DMA_TBS_FTOV)
>>   
>> -/* Following DMA defines are chanels oriented */
>> +/* Following DMA defines are channels oriented */
> I'm not a native speaker but I'd spell it "... are channel-oriented"
> With a hyphen, channel not channels.
>
>>   #define DMA_CHAN_BASE_ADDR		0x00001100
>>   #define DMA_CHAN_BASE_OFFSET		0x80
>>