netdev - Re: [PATCH v2 net-next 01/14] rtnetlink: prepare nla_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+UXeRoG4yMF+xYVDDNv-j2iZYTwUogQWsHk_OiDwoukA@mail.gmail.com>
Date: Sat, 24 Feb 2024 09:21:24 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Donald Hunter <donald.hunter@...il.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	Ido Schimmel <idosch@...dia.com>, Jiri Pirko <jiri@...dia.com>, eric.dumazet@...il.com
Subject: Re: [PATCH v2 net-next 01/14] rtnetlink: prepare nla_put_iflink() to
 run under RCU

On Fri, Feb 23, 2024 at 4:25 PM Donald Hunter <donald.hunter@...il.com> wrote:
>
> Eric Dumazet <edumazet@...gle.com> writes:
>
> > We want to be able to run rtnl_fill_ifinfo() under RCU protection
> > instead of RTNL in the future.
> >
> > This patch prepares dev_get_iflink() and nla_put_iflink()
> > to run either with RTNL or RCU held.
> >
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>
> I notice that several of the *_get_iflink() implementations are wrapped
> with rcu_read_lock()/unlock() and many are not. Shouldn't this be done
> consistently for all?

I do not understand the question, could you give one example of what
you saw so that I can comment ?

We do not need an rcu_read_lock() only to fetch dev->ifindex, if this
is what concerns you.