netdev - Re: [PATCH net] veth: try harder when allocating queue memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 24 Feb 2024 09:25:32 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com, 
	Miao Wang <shankerwangmiao@...il.com>
Subject: Re: [PATCH net] veth: try harder when allocating queue memory

On Sat, Feb 24, 2024 at 12:59 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> struct veth_rq is pretty large, 832B total without debug
> options enabled. Since commit under Fixes we try to pre-allocate
> enough queues for every possible CPU. Miao Wang reports that
> this may lead to order-5 allocations which will fail in production.
>
> Let the allocation fallback to vmalloc() and try harder.
> These are the same flags we pass to netdev queue allocation.
>
> Reported-and-tested-by: Miao Wang <shankerwangmiao@...il.com>
> Fixes: 9d3684c24a52 ("veth: create by default nr_possible_cpus queues")
> Link: https://lore.kernel.org/all/5F52CAE2-2FB7-4712-95F1-3312FBBFA8DD@gmail.com/
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

This reminds me a change that we should do in
netlink_alloc_large_skb(), using kvmalloc() instead of vmalloc().