netdev - Re: [PATCH net-next v3 04/10] net: ti: icssg-prueth: Add SR1.0-specific configuration bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a2c7175-e7f5-42b7-9a3e-dd727eed259a@siemens.com>
Date: Tue, 27 Feb 2024 11:46:48 +0000
From: Diogo Ivo <diogo.ivo@...mens.com>
To: Roger Quadros <rogerq@...nel.org>, danishanwar@...com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, andrew@...n.ch, linux-arm-kernel@...ts.infradead.org,
 netdev@...r.kernel.org
Cc: jan.kiszka@...mens.com
Subject: Re: [PATCH net-next v3 04/10] net: ti: icssg-prueth: Add
 SR1.0-specific configuration bits

On 2/26/24 17:23, Roger Quadros wrote:
> Hi Diogo,
> 
> On 21/02/2024 17:24, Diogo Ivo wrote:
>> Define the firmware configuration structure and commands needed to
>> communicate with SR1.0 firmware, as well as SR1.0 buffer information
>> where it differs from SR2.0.
>>
>> +/* SR1.0 defines */
>> +#define PRUETH_MAX_RX_FLOWS_SR1		4	/* excluding default flow */
>> +#define PRUETH_RX_FLOW_DATA_SR1		3       /* highest priority flow */
>> +#define PRUETH_MAX_RX_MGM_DESC		8
>> +#define PRUETH_MAX_RX_MGM_FLOWS		2	/* excluding default flow */
>> +#define PRUETH_RX_MGM_FLOW_RESPONSE	0
>> +#define PRUETH_RX_MGM_FLOW_TIMESTAMP	1
> 
> Should we add suffix _SR1 to all SR1 specific macro names?
>> +#define ICSSG_SHUTDOWN_CMD		0x81010000
>> +
>> +/* SR1.0 pstate speed/duplex command to set speed and duplex settings
>> + * in firmware.
>> + * Command format: 0x8102ssPN, where
>> + *	- ss: sequence number. Currently not used by driver.
>> + *	- P: port number (for switch mode).
>> + *	- N: Speed/Duplex state:
>> + *		0x0 - 10Mbps/Half duplex;
>> + *		0x8 - 10Mbps/Full duplex;
>> + *		0x2 - 100Mbps/Half duplex;
>> + *		0xa - 100Mbps/Full duplex;
>> + *		0xc - 1Gbps/Full duplex;
>> + *		NOTE: The above are the same value as bits [3..1](slice 0)
>> + *		      or bits [7..5](slice 1) of RGMII CFG register.
>> + */
>> +#define ICSSG_PSTATE_SPEED_DUPLEX_CMD	0x81020000
>> +
> 
> How about bunching all S1.0 related changes at one place in this file?

Both suggestions sound good, I'll add the missing _SR1 suffixes and move
things together down in the file for v4.

Best regards,
Diogo