netdev - Re: [PATCH net-next 13/13] ipv6: use xa_array iterator to implement inet6_netconf_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 27 Feb 2024 12:49:17 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jiri Pirko <jiri@...nulli.us>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com
Subject: Re: [PATCH net-next 13/13] ipv6: use xa_array iterator to implement inet6_netconf_dump_devconf()

On Mon, Feb 26, 2024 at 5:55 PM Jiri Pirko <jiri@...nulli.us> wrote:
>
> Mon, Feb 26, 2024 at 04:50:55PM CET, edumazet@...gle.com wrote:
> >1) inet6_netconf_dump_devconf() can run under RCU protection
> >   instead of RTNL.
>

> >+              ctx->all_default++;
> >       }
> >-done:
> >-      cb->args[0] = h;
> >-      cb->args[1] = idx;
> >-
> >-      return skb->len;
> >+done: if (err < 0 && likely(skb->len))
>
> It is common to not mix label and other statement on the same line,
> could you split?

Sure thing !

>
> Otherwise the patch and the set looks good to me. Thanks!
>
>