netdev - Re: [PATCH net 1/2] net: dsa: mv88e6xxx: fix marvell 6320/21 switch probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240227182121.055df038@kernel.org>
Date: Tue, 27 Feb 2024 18:21:21 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Steffen Bätz <steffen@...osonix.de>
Cc: Fabio Estevam <festevam@...il.com>, Andrew Lunn <andrew@...n.ch>,
 Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean
 <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Russell King
 <linux@...linux.org.uk>, "Russell King (Oracle)"
 <rmk+kernel@...linux.org.uk>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 1/2] net: dsa: mv88e6xxx: fix marvell 6320/21 switch
 probing

On Mon, 26 Feb 2024 10:13:23 +0100 Steffen Bätz wrote:
> +static void mv88e632x_phylink_get_caps(struct mv88e6xxx_chip *chip, int port,
> +				       struct phylink_config *config)
> +{
> +	unsigned long *supported = config->supported_interfaces;
> +	int err, cmode;

err and cmode are unused in this patch, please move cmode addition
to patch 2 and drop err which appears to remain unused after patch 2.
-- 
pw-bot: cr