[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240228125344.GD292522@kernel.org>
Date: Wed, 28 Feb 2024 12:53:44 +0000
From: Simon Horman <horms@...nel.org>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Jonathan Corbet <corbet@....net>,
Luis Chamberlain <mcgrof@...nel.org>,
Russ Weight <russ.weight@...ux.dev>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Oleksij Rempel <o.rempel@...gutronix.de>,
Mark Brown <broonie@...nel.org>,
Frank Rowand <frowand.list@...il.com>, Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-doc@...r.kernel.org, devicetree@...r.kernel.org,
Dent Project <dentproject@...uxfoundation.org>
Subject: Re: [PATCH net-next v5 17/17] net: pse-pd: Add TI TPS23881 PSE
controller driver
On Tue, Feb 27, 2024 at 03:42:59PM +0100, Kory Maincent wrote:
> Add a new driver for the TI TPS23881 I2C Power Sourcing Equipment
> controller.
>
> This patch is sponsored by Dent Project <dentproject@...uxfoundation.org>.
>
> Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
...
> +static int tps23881_flash_fw_part(struct i2c_client *client,
> + const char *fw_name,
> + const struct tps23881_fw_conf *fw_conf)
> +{
> + const struct firmware *fw = NULL;
> + int i, ret;
> +
> + ret = request_firmware(&fw, fw_name, &client->dev);
> + if (ret)
> + return ret;
> +
> + dev_info(&client->dev, "Flashing %s\n", fw_name);
> +
> + /* Prepare device for RAM download */
> + while (fw_conf->reg) {
> + ret = i2c_smbus_write_byte_data(client, fw_conf->reg,
> + fw_conf->val);
> + if (ret < 0)
Hi Kory,
Should fw be released here.
> + return ret;
> +
> + fw_conf++;
> + }
> +
> + /* Flash the firmware file */
> + for (i = 0; i < fw->size; i++) {
> + ret = i2c_smbus_write_byte_data(client,
> + TPS23881_REG_SRAM_DATA,
> + fw->data[i]);
> + if (ret < 0)
And here?
Flagged by Smatch.
> + return ret;
> + }
> +
> + release_firmware(fw);
> +
> + return 0;
> +}
...
Powered by blists - more mailing lists