netdev - Re: [PATCH v2] net: hsr: Use correct offset for HSR TLV values in supervisory HSR frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b6e7f4bc7e664950889c4d46f2e5dcf9e66986a.camel@redhat.com>
Date: Thu, 29 Feb 2024 11:10:00 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Jiri Pirko <jiri@...nulli.us>, Lukasz Majewski <lukma@...x.de>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>, Andrew Lunn <andrew@...n.ch>, 
 Eric Dumazet <edumazet@...gle.com>, Florian Fainelli
 <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, "David S.
 Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 netdev@...r.kernel.org, Tristram.Ha@...rochip.com,  Sebastian Andrzej
 Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH v2] net: hsr: Use correct offset for HSR TLV values in
 supervisory HSR frames

On Wed, 2024-02-28 at 13:31 +0100, Jiri Pirko wrote:
> Wed, Feb 28, 2024 at 09:56:44AM CET, lukma@...x.de wrote:
> > Current HSR implementation uses following supervisory frame (even for
> > HSRv1 the HSR tag is not is not present):
> > 
> > 00000000: 01 15 4e 00 01 2d XX YY ZZ 94 77 10 88 fb 00 01
> > 00000010: 7e 1c 17 06 XX YY ZZ 94 77 10 1e 06 XX YY ZZ 94
> > 00000020: 77 10 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > 00000030: 00 00 00 00 00 00 00 00 00 00 00 00
> > 
> > The current code adds extra two bytes (i.e. sizeof(struct hsr_sup_tlv))
> > when offset for skb_pull() is calculated.
> > This is wrong, as both 'struct hsrv1_ethhdr_sp' and 'hsrv0_ethhdr_sp'
> > already have 'struct hsr_sup_tag' defined in them, so there is no need
> > for adding extra two bytes.
> > 
> > This code was working correctly as with no RedBox support, the check for
> > HSR_TLV_EOT (0x00) was off by two bytes, which were corresponding to
> > zeroed padded bytes for minimal packet size.
> > 
> > Fixes: eafaa88b3eb7 ("net: hsr: Add support for redbox supervision frames")
> > 
> 
> And yet the extra empty line is still here :/

To avoid more back & forth on otherwise correct patch, I'll fix this
while applying the patch. I hope it's clear to everybody this is an
exception and not the new normal :)

> > Signed-off-by: Lukasz Majewski <lukma@...x.de>

Please have a better look to the Documentation before the next post,
and use the checkpatch script before the submission.

Thanks,

Paolo