netdev - Re: [PATCH net-next v3 08/10] net: ti: icssg-prueth: Add functions to configure SR1.0 packet classifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <547710c1-eba3-4006-9285-f2528fac3e1b@kernel.org>
Date: Thu, 29 Feb 2024 12:16:34 +0200
From: Roger Quadros <rogerq@...nel.org>
To: Diogo Ivo <diogo.ivo@...mens.com>, danishanwar@...com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, andrew@...n.ch, dan.carpenter@...aro.org,
 linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org
Cc: jan.kiszka@...mens.com
Subject: Re: [PATCH net-next v3 08/10] net: ti: icssg-prueth: Add functions to
 configure SR1.0 packet classifier



On 27/02/2024 14:14, Diogo Ivo wrote:
> On 2/26/24 18:41, Roger Quadros wrote:
>>
>>
>> On 21/02/2024 17:24, Diogo Ivo wrote:
>>> Add the functions to configure the SR1.0 packet classifier.
>>>
>>> Based on the work of Roger Quadros in TI's 5.10 SDK [1].
>>>
>>> [1]: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ti.com%2Fcgit%2Fti-linux-kernel%2Fti-linux-kernel%2Ftree%2F%3Fh%3Dti-linux-5.10.y&data=05%7C02%7Cdiogo.ivo%40siemens.com%7Ca43411e60ce048593e7408dc36fa7f73%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C638445696707314198%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=v%2B%2FkgG1q31vJYa5a%2B5zYTbdxJbq5TKVOGT0Aavnk97Q%3D&reserved=0
>>>
>>> Co-developed-by: Jan Kiszka <jan.kiszka@...mens.com>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
>>> Signed-off-by: Diogo Ivo <diogo.ivo@...mens.com>
>>> ---
>>> Changes in v3:
>>>   - Replace local variables in icssg_class_add_mcast_sr1()
>>>     with eth_reserved_addr_base and eth_ipv4_mcast_addr_base
>>>
>>>   .../net/ethernet/ti/icssg/icssg_classifier.c  | 113 ++++++++++++++++--
>>>   drivers/net/ethernet/ti/icssg/icssg_prueth.c  |   2 +-
>>>   drivers/net/ethernet/ti/icssg/icssg_prueth.h  |   6 +-
>>>   3 files changed, 110 insertions(+), 11 deletions(-)
> 
> ...
> 
>> Build fails with
>>
>> drivers/net/ethernet/ti/icssg/icssg_classifier.c:428:7: error: ‘eth_ipv4_mcast_addr_base’ undeclared (first use in this function)
>>    428 |       eth_ipv4_mcast_addr_base, mask_addr);
>>        |       ^~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Is there a dependency patch?
> 
> Yes, this patch depends on patch 02/10 of the series, apologies for not
> mentioning it explicitly.

You don't have to mention it explicitly. Patc 2 didn't arrive at my inbox and
I didn't notice it. It was my bad, sorry.

-- 
cheers,
-roger