netdev - Re: [PATCH net-next v3 08/10] net: ti: icssg-prueth: Add functions to configure SR1.0 packet classifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69db7d23-6c24-4b44-9222-94560b6c065b@kernel.org>
Date: Thu, 29 Feb 2024 12:15:43 +0200
From: Roger Quadros <rogerq@...nel.org>
To: Diogo Ivo <diogo.ivo@...mens.com>, danishanwar@...com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, andrew@...n.ch, dan.carpenter@...aro.org,
 linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org
Cc: jan.kiszka@...mens.com
Subject: Re: [PATCH net-next v3 08/10] net: ti: icssg-prueth: Add functions to
 configure SR1.0 packet classifier



On 27/02/2024 14:11, Diogo Ivo wrote:
> On 2/26/24 17:26, Roger Quadros wrote:
>>
>>
>> On 21/02/2024 17:24, Diogo Ivo wrote:
>>> Add the functions to configure the SR1.0 packet classifier.
>>>
>>> Based on the work of Roger Quadros in TI's 5.10 SDK [1].
>>>
>>> [1]: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ti.com%2Fcgit%2Fti-linux-kernel%2Fti-linux-kernel%2Ftree%2F%3Fh%3Dti-linux-5.10.y&data=05%7C02%7Cdiogo.ivo%40siemens.com%7C5db0233cf1944b0b012808dc36f0214c%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C638445652187413851%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=u4p0vZ6LCPScUuYuwCB2iJFm6uoz%2BDMesVWnTgwg1hs%3D&reserved=0
>>>
>>> Co-developed-by: Jan Kiszka <jan.kiszka@...mens.com>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
>>> Signed-off-by: Diogo Ivo <diogo.ivo@...mens.com>
>>> ---
>>> Changes in v3:
>>>   - Replace local variables in icssg_class_add_mcast_sr1()
>>>     with eth_reserved_addr_base and eth_ipv4_mcast_addr_base
>>>
> 
> ...
> 
>>> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
>>> index e6eac01f9f99..7d9db9683e18 100644
>>> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
>>> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
>>> @@ -437,7 +437,7 @@ static int emac_ndo_open(struct net_device *ndev)
>>>       icssg_class_set_mac_addr(prueth->miig_rt, slice, emac->mac_addr);
>>>       icssg_ft1_set_mac_addr(prueth->miig_rt, slice, emac->mac_addr);
>>>   -    icssg_class_default(prueth->miig_rt, slice, 0);
>>> +    icssg_class_default(prueth->miig_rt, slice, 0, false);
>>
>> Should you be passing emac->is_sr1 instead of false?
> 
> Given that this is the SR2.0 driver we know that bool is_sr1 will always
> be false, is there an advantage in passing emac->is_sr1 rather than
> false directly?

Ah, no there isn't. You can leave it as it is.

-- 
cheers,
-roger