[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240228180520.5cea0f8b@kernel.org>
Date: Wed, 28 Feb 2024 18:05:20 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Rahul Rameshbabu <rrameshbabu@...dia.com>
Cc: Saeed Mahameed <saeed@...nel.org>, Leon Romanovsky <leon@...nel.org>,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet
<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jonathan Corbet
<corbet@....net>, Richard Cochran <richardcochran@...il.com>, Tariq Toukan
<tariqt@...dia.com>, Gal Pressman <gal@...dia.com>, Vadim Fedorenko
<vadim.fedorenko@...ux.dev>, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit
<hkallweit1@...il.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
Ahmed Zaki <ahmed.zaki@...el.com>, Alexander Lobakin
<aleksander.lobakin@...el.com>, Hangbin Liu <liuhangbin@...il.com>, Paul
Greenwalt <paul.greenwalt@...el.com>, Justin Stitt
<justinstitt@...gle.com>, Randy Dunlap <rdunlap@...radead.org>, Maxime
Chevallier <maxime.chevallier@...tlin.com>, Kory Maincent
<kory.maincent@...tlin.com>, Wojciech Drewek <wojciech.drewek@...el.com>,
Vladimir Oltean <vladimir.oltean@....com>, Jiri Pirko <jiri@...nulli.us>,
Jacob Keller <jacob.e.keller@...el.com>, Alexandre Torgue
<alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, Dragos
Tatulea <dtatulea@...dia.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH RFC net-next v1 1/6] ethtool: add interface to read Tx
hardware timestamping statistics
On Fri, 23 Feb 2024 11:24:45 -0800 Rahul Rameshbabu wrote:
> +/**
> + * struct ethtool_ts_stats - HW timestamping statistics
> + * @layer: input field denoting whether stats should be queried from the DMA or
> + * PHY timestamping layer. Defaults to the active layer for packet
> + * timestamping.
I think we're better off attaching this to an existing message in the
dump (using ETHTOOL_FLAG_STATS / ethtool -I), like we do for pause,
fec, etc., rather than having to build a separate hierarchy and copy
identifiers within ETHTOOL_MSG_STATS_GET.
Sorry if I mis-directed you this way.
Powered by blists - more mailing lists