netdev - Re: [PATCH net] kunit: Fix again checksum tests on big endian CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-27f419e8-9551-4a63-a74a-cede3f9d2614@palmer-ri-x1c9>
Date: Wed, 28 Feb 2024 17:55:42 -0800 (PST)
From: Palmer Dabbelt <palmer@...belt.com>
To: kuba@...nel.org
CC: akpm@...ux-foundation.org, pabeni@...hat.com, linux-kernel@...r.kernel.org,
  netdev@...r.kernel.org, Charlie Jenkins <charlie@...osinc.com>, erhard_f@...lbox.org,
  christophe.leroy@...roup.eu, davem@...emloft.net
Subject:     Re: [PATCH net] kunit: Fix again checksum tests on big endian CPUs

On Wed, 28 Feb 2024 17:51:58 PST (-0800), kuba@...nel.org wrote:
> On Tue, 27 Feb 2024 10:06:41 +0100 Paolo Abeni wrote:
>> On Sat, 2024-02-24 at 07:44 +0000, Christophe Leroy wrote:
>> > Hi,
>> > 
>> > Le 23/02/2024 à 11:41, Christophe Leroy a écrit :  
>> > > Commit b38460bc463c ("kunit: Fix checksum tests on big endian CPUs")
>> > > fixed endianness issues with kunit checksum tests, but then
>> > > commit 6f4c45cbcb00 ("kunit: Add tests for csum_ipv6_magic and
>> > > ip_fast_csum") introduced new issues on big endian CPUs. Those issues
>> > > are once again reflected by the warnings reported by sparse.
>> > > 
>> > > So, fix them with the same approach, perform proper conversion in
>> > > order to support both little and big endian CPUs. Once the conversions
>> > > are properly done and the right types used, the sparse warnings are
>> > > cleared as well.
>> > > 
>> > > Reported-by: Erhard Furtner <erhard_f@...lbox.org>
>> > > Fixes: 6f4c45cbcb00 ("kunit: Add tests for csum_ipv6_magic and ip_fast_csum")
>> > > Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>  
>> > 
>> > netdev checkpatch complains about "1 blamed authors not CCed: 
>> > palmer@...osinc.com; 1 maintainers not CCed: palmer@...osinc.com "
>> > 
>> > Palmer was copied but as Palmer Dabbelt <palmer@...belt.com>. Hope it is 
>> > not a show stopper.  
>> 
>> No, it's not.
>> 
>> Acked-by: Paolo Abeni <pabeni@...hat.com>
>> 
>> I *think* this, despite the subject prefix, should go via Andrew's tree
>> to avoid conflicts.
>> 
>> @Andrew does the above fits you?
>
> I don't see this in linux-next, so unless told otherwise I'll merge it
> and ship to Linus tomorrow.

Sorry, I thought I'd Ack'd this at some point -- I might have just 
gotten lost, though, as IIRC there were a few of these floating around.

I'm fine with anyone taking it, so

Acked-by: Palmer Dabbelt <palmer@...osinc.com>

Thanks!