netdev - Re: [PATCH net-next] net: page_pool: make page_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC_iWj+5TMe8ixXrLM3DUS+RAmDu+gmb1rfcHiU04re8phQVDA@mail.gmail.com>
Date: Fri, 1 Mar 2024 12:27:31 +0200
From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, lorenzo.bianconi@...hat.com, 
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, hawk@...nel.org
Subject: Re: [PATCH net-next] net: page_pool: make page_pool_create inline

Hi Lorenzo,

On Wed, 14 Feb 2024 at 21:14, Lorenzo Bianconi <lorenzo@...nel.org> wrote:
>
> > On Wed, 14 Feb 2024 19:01:28 +0100 Lorenzo Bianconi wrote:
> > > Make page_pool_create utility routine inline a remove exported symbol.
> >
> > But why? If you add the kdoc back the LoC saved will be 1.
>
> I would remove the symbol exported since it is just a wrapper for
> page_pool_create_percpu()

I don't mind either. But the explanation above must be part of the
commit message.

Thanks
/Ilias
>
> >
> > >  include/net/page_pool/types.h |  6 +++++-
> > >  net/core/page_pool.c          | 10 ----------
> > >  2 files changed, 5 insertions(+), 11 deletions(-)
> >
> > No strong opinion, but if you want to do it please put the helper
> > in helpers.h  Let's keep the static inlines clearly separated.
>
> ack, fine to me. I put it there since we already have some inlines in
> page_pool/types.h.
>
> Regards,
> Lorenzo