netdev - Re: [PATCH net-next] net: page_pool: make page_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3047f5c-673e-4891-94b6-f2448c5385dd@kernel.org>
Date: Fri, 1 Mar 2024 11:33:45 +0100
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Ilias Apalodimas <ilias.apalodimas@...aro.org>,
 Lorenzo Bianconi <lorenzo@...nel.org>
Cc: Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
 lorenzo.bianconi@...hat.com, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com
Subject: Re: [PATCH net-next] net: page_pool: make page_pool_create inline



On 01/03/2024 11.27, Ilias Apalodimas wrote:
> 
> On Wed, 14 Feb 2024 at 21:14, Lorenzo Bianconi <lorenzo@...nel.org> wrote:
>>
>>> On Wed, 14 Feb 2024 19:01:28 +0100 Lorenzo Bianconi wrote:
>>>> Make page_pool_create utility routine inline a remove exported symbol.
>>>
>>> But why? If you add the kdoc back the LoC saved will be 1.
>>
>> I would remove the symbol exported since it is just a wrapper for
>> page_pool_create_percpu()
> 
> I don't mind either. But the explanation above must be part of the
> commit message.

I hope my benchmark module will still work...

https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/bench_page_pool_simple.c#L181


--Jesper