netdev - Re: [PATCH net-next v2 1/7] net: nexthop: Adjust netlink policy parsing for a new attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab3af787-d44f-43b8-b90a-5520d4df3686@kernel.org>
Date: Fri, 1 Mar 2024 08:31:24 -0700
From: David Ahern <dsahern@...nel.org>
To: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc: Ido Schimmel <idosch@...dia.com>, Simon Horman <horms@...nel.org>,
 mlxsw@...dia.com
Subject: Re: [PATCH net-next v2 1/7] net: nexthop: Adjust netlink policy
 parsing for a new attribute

On 2/29/24 11:16 AM, Petr Machata wrote:
> A following patch will introduce a new attribute, op-specific flags to
> adjust the behavior of an operation. Different operations will recognize
> different flags.
> 
> - To make the differentiation possible, stop sharing the policies for get
>   and del operations.
> 
> - To allow querying for presence of the attribute, have all the attribute
>   arrays sized to NHA_MAX, regardless of what is permitted by policy, and
>   pass the corresponding value to nlmsg_parse() as well.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> ---
>  net/ipv4/nexthop.c | 58 ++++++++++++++++++++++------------------------
>  1 file changed, 28 insertions(+), 30 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>