[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3442deb7-df7d-4ee5-98f0-fa708838a93c@kernel.org>
Date: Fri, 1 Mar 2024 08:36:10 -0700
From: David Ahern <dsahern@...nel.org>
To: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc: Ido Schimmel <idosch@...dia.com>, Simon Horman <horms@...nel.org>,
mlxsw@...dia.com
Subject: Re: [PATCH net-next v2 2/7] net: nexthop: Add NHA_OP_FLAGS
On 2/29/24 11:16 AM, Petr Machata wrote:
> In order to add per-nexthop statistics, but still not increase netlink
> message size for consumers that do not care about them, there needs to be a
> toggle through which the user indicates their desire to get the statistics.
> To that end, add a new attribute, NHA_OP_FLAGS. The idea is to be able to
> use the attribute for carrying of arbitrary operation-specific flags, i.e.
> not make it specific for get / dump.
>
> Add the new attribute to get and dump policies, but do not actually allow
> any flags yet -- those will come later as the flags themselves are defined.
> Add the necessary parsing code.
>
> Signed-off-by: Petr Machata <petrm@...dia.com>
> ---
>
> Notes:
> v2:
> - Change OP_FLAGS to u32, enforce through NLA_POLICY_MASK
>
> include/uapi/linux/nexthop.h | 3 +++
> net/ipv4/nexthop.c | 24 ++++++++++++++++++++----
> 2 files changed, 23 insertions(+), 4 deletions(-)
>
Reviewed-by: David Ahern <dsahern@...nel.org>
Powered by blists - more mailing lists