netdev - Re: [PATCH net-next 0/2] add two missing addresses when using trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoBJy4a_wBQbwmvWZWZP7mwaby3xHy+45x-PTEbHsGAH6A@mail.gmail.com>
Date: Mon, 4 Mar 2024 15:00:38 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: edumazet@...gle.com, mhiramat@...nel.org, mathieu.desnoyers@...icios.com, 
	rostedt@...dmis.org, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, linux-trace-kernel@...r.kernel.org, 
	Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net-next 0/2] add two missing addresses when using trace

On Fri, Mar 1, 2024 at 1:10 AM Jason Xing <kerneljasonxing@...il.com> wrote:
>
> From: Jason Xing <kernelxing@...cent.com>
>
> When I reviewed other people's patch [1], I noticed that similar thing
> also happens in tcp_event_skb class and tcp_event_sk_skb class. They
> don't print those two addrs of skb/sk which already exist.
>
> They are probably forgotten by the original authors, so this time I
> finish the work. Also, adding more trace about the socket/skb addr can
> help us sometime even though the chance is minor.
>
> I don't consider it is a bug, thus I chose to target net-next tree.

Gentle ping...No rush. Just in case this simple patchset was lost for
some reason.

Thanks,
Jason

>
> [1]
> Link: https://lore.kernel.org/netdev/CAL+tcoAhvFhXdr1WQU8mv_6ZX5nOoNpbOLAB6=C+DB-qXQ11Ew@mail.gmail.com/
>
> Jason Xing (2):
>   tcp: add tracing of skb/skaddr in tcp_event_sk_skb class
>   tcp: add tracing of skbaddr in tcp_event_skb class
>
>  include/trace/events/tcp.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> --
> 2.37.3
>