[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <65e6e40618790_3cfad29492@willemb.c.googlers.com.notmuch>
Date: Tue, 05 Mar 2024 04:21:10 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Breno Leitao <leitao@...ian.org>,
kuba@...nel.org,
davem@...emloft.net,
pabeni@...hat.com,
edumazet@...gle.com,
Willem de Bruijn <willemdebruijn.kernel@...il.com>,
Jason Wang <jasowang@...hat.com>
Cc: netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
horms@...nel.org,
dsahern@...nel.org
Subject: Re: [PATCH net-next 2/2] net: tap: Remove generic .ndo_get_stats64
Breno Leitao wrote:
> Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is
> configured") moved the callback to dev_get_tstats64() to net core, so,
> unless the driver is doing some custom stats collection, it does not
> need to set .ndo_get_stats64.
>
> Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
> doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
> function pointer.
>
> Signed-off-by: Breno Leitao <leitao@...ian.org>
Reviewed-by: Willem de Bruijn <willemb@...gle.com>
Powered by blists - more mailing lists