netdev - Re: [PATCH net-next 1/2] net: tuntap: Leverage core stats allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65e6e3f62c314_3cfad29462@willemb.c.googlers.com.notmuch>
Date: Tue, 05 Mar 2024 04:20:54 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Breno Leitao <leitao@...ian.org>, 
 kuba@...nel.org, 
 davem@...emloft.net, 
 pabeni@...hat.com, 
 edumazet@...gle.com, 
 Willem de Bruijn <willemdebruijn.kernel@...il.com>, 
 Jason Wang <jasowang@...hat.com>
Cc: netdev@...r.kernel.org, 
 linux-kernel@...r.kernel.org, 
 horms@...nel.org, 
 dsahern@...nel.org
Subject: Re: [PATCH net-next 1/2] net: tuntap: Leverage core stats allocator

Breno Leitao wrote:
> With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and
> convert veth & vrf"), stats allocation could be done on net core
> instead of in this driver.
> 
> With this new approach, the driver doesn't have to bother with error
> handling (allocation failure checking, making sure free happens in the
> right spot, etc). This is core responsibility now.
> 
> Remove the allocation in the tun/tap driver and leverage the network
> core allocation instead.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>