[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240304183810.1474883-2-leitao@debian.org>
Date: Mon, 4 Mar 2024 10:38:08 -0800
From: Breno Leitao <leitao@...ian.org>
To: kuba@...nel.org,
davem@...emloft.net,
pabeni@...hat.com,
edumazet@...gle.com,
Willem de Bruijn <willemdebruijn.kernel@...il.com>,
Jason Wang <jasowang@...hat.com>
Cc: netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
horms@...nel.org,
dsahern@...nel.org
Subject: [PATCH net-next 2/2] net: tap: Remove generic .ndo_get_stats64
Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is
configured") moved the callback to dev_get_tstats64() to net core, so,
unless the driver is doing some custom stats collection, it does not
need to set .ndo_get_stats64.
Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
function pointer.
Signed-off-by: Breno Leitao <leitao@...ian.org>
---
drivers/net/tun.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 6c594a3c2c37..8d258e263f54 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -1338,7 +1338,6 @@ static const struct net_device_ops tap_netdev_ops = {
.ndo_select_queue = tun_select_queue,
.ndo_features_check = passthru_features_check,
.ndo_set_rx_headroom = tun_set_headroom,
- .ndo_get_stats64 = dev_get_tstats64,
.ndo_bpf = tun_xdp,
.ndo_xdp_xmit = tun_xdp_xmit,
.ndo_change_carrier = tun_net_change_carrier,
--
2.43.0
Powered by blists - more mailing lists