netdev - Re: [PATCH net-next v9 08/13] ptp: Add phc source and helpers to register specific PTP clock or get information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240305111021.5c892d5a@kmaincent-XPS-13-7390>
Date: Tue, 5 Mar 2024 11:10:21 +0100
From: Köry Maincent <kory.maincent@...tlin.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Jakub Kicinski <kuba@...nel.org>, Florian Fainelli
 <florian.fainelli@...adcom.com>, Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn <andrew@...n.ch>,
 Heiner Kallweit <hkallweit1@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>, Radu Pirea
 <radu-nicolae.pirea@....nxp.com>, Jay Vosburgh <j.vosburgh@...il.com>, Andy
 Gospodarek <andy@...yhouse.net>, Nicolas Ferre
 <nicolas.ferre@...rochip.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
 Willem de Bruijn <willemdebruijn.kernel@...il.com>, Jonathan Corbet
 <corbet@....net>, Horatiu Vultur <horatiu.vultur@...rochip.com>,
 UNGLinuxDriver@...rochip.com, Simon Horman <horms@...nel.org>, Vladimir
 Oltean <vladimir.oltean@....com>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, Maxime Chevallier
 <maxime.chevallier@...tlin.com>, Rahul Rameshbabu <rrameshbabu@...dia.com>
Subject: Re: [PATCH net-next v9 08/13] ptp: Add phc source and helpers to
 register specific PTP clock or get information

On Tue, 5 Mar 2024 08:36:54 +0000
"Russell King (Oracle)" <linux@...linux.org.uk> wrote:

> On Mon, Mar 04, 2024 at 06:57:34PM -0800, Jakub Kicinski wrote:
> > On Mon, 26 Feb 2024 14:39:59 +0100 Kory Maincent wrote:  
> > > Prepare for future hardware timestamp selection by adding source and
> > > corresponding pointers to ptp_clock structure. Additionally, introduce
> > > helpers for registering specific phydev or netdev PTP clocks, retrieving
> > > PTP clock information such as hwtstamp source or phydev/netdev pointers,
> > > and obtaining the ptp_clock structure from the phc index.  
> > 
> > Can we assume there's one PHC per netdev?
> > We both store the netdev/phydev info in the ptp clock
> > and ptp clock in the netdev. Is there a reason for that?  
> 
> No. In the case of mvpp2 + marvell PHY, the two PTP implementations are
> entirely separate.

Yes the PTP clock can be independent from the netdev.
We need to know which software layer register the PHC to be able to call its
callbacks.

My commit log is a bit small here. I will enhance it in the next version.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com