netdev - Re: [PATCH] net: bcmgenet: Reset RBUF on first open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45ba80640e989541e142c32fb3520589@rmail.be>
Date: Tue, 05 Mar 2024 21:36:03 +0100
From: Maarten <maarten@...il.be>
To: Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, Broadcom
 internal kernel review list <bcm-kernel-feedback-list@...adcom.com>
Cc: Doug Berger <opendmb@...il.com>, Florian Fainelli
 <florian.fainelli@...adcom.com>, Phil Elwell <phil@...pberrypi.com>
Subject: Re: [PATCH] net: bcmgenet: Reset RBUF on first open

Jakub Kicinski schreef op 2024-03-05 16:13:
> On Mon, 26 Feb 2024 15:13:57 -0800 Doug Berger wrote:
>> I agree that the Linux driver expects the GENET core to be in a "quasi
>> power-on-reset state" and it seems likely that in both Maxime's case 
>> and
>> the one identified here that is not the case. It would appear that the
>> Raspberry Pi bootloader and/or "firmware" are likely not disabling the
>> GENET receiver after loading the kernel image and before invoking the
>> kernel. They may be disabling the DMA, but that is insufficient since
>> any received data would likely overflow the RBUF leaving it in a "bad"
>> state which this patch apparently improves.
>> 
>> So it seems likely these issues are caused by improper
>> bootloader/firmware behavior.
>> 
>> That said, I suppose it would be nice if the driver were more robust.
>> However, we both know how finicky the receive path of the GENET core 
>> can
>> be about its initialization. Therefore, I am unwilling to "bless" this
>> change for upstream without more due diligence on our side.
> 
> The patch has minor formatting issues (using spaces to indent).
> Once you've gain sufficient confidence that it doesn't cause issues -
> please mend that and repost.

I'm sorry, it was blatantly obvious and I missed it :-( . I had added 
indent-with-non-tab to git core.whitespace , but it seems to only error 
when a full 8 spaces are present in indentation. By any chance, is there 
something to test this? In the main time, I'll do a git show -p --raw | 
hexdump -C to check this .

I've fixed that on my git (and fixed some similar issues in other 
patches) and will resend.

thanks,

Maarten