netdev - Re: [PATCH] net: bcmgenet: Reset RBUF on first open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240305130728.5d879a7e@kernel.org>
Date: Tue, 5 Mar 2024 13:07:28 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Maarten <maarten@...il.be>
Cc: netdev@...r.kernel.org, Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Doug Berger <opendmb@...il.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>, Phil Elwell
 <phil@...pberrypi.com>
Subject: Re: [PATCH] net: bcmgenet: Reset RBUF on first open

On Tue, 05 Mar 2024 21:36:03 +0100 Maarten wrote:
> > The patch has minor formatting issues (using spaces to indent).
> > Once you've gain sufficient confidence that it doesn't cause issues -
> > please mend that and repost.  
> 
> I'm sorry, it was blatantly obvious and I missed it :-( . I had added 
> indent-with-non-tab to git core.whitespace , but it seems to only error 
> when a full 8 spaces are present in indentation. By any chance, is there 
> something to test this? In the main time, I'll do a git show -p --raw | 
> hexdump -C to check this .
> 
> I've fixed that on my git (and fixed some similar issues in other 
> patches) and will resend.

I'd rather you waited with the resend until Doug or Florian confirms
the change is okay. No point having the patch rot in patchwork until
then.