netdev - Re: [PATCH net-next v4 05/10] net: ti: icssg-prueth: Add SR1.0-specific description bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cdaee2b-bf1d-4528-8578-b58ee3904095@siemens.com>
Date: Wed, 6 Mar 2024 11:26:36 +0000
From: Diogo Ivo <diogo.ivo@...mens.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: danishanwar@...com, rogerq@...nel.org, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, andrew@...n.ch,
 linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
 jan.kiszka@...mens.com
Subject: Re: [PATCH net-next v4 05/10] net: ti: icssg-prueth: Add
 SR1.0-specific description bits

On 3/5/24 14:41, Russell King (Oracle) wrote:
> On Tue, Mar 05, 2024 at 11:40:25AM +0000, Diogo Ivo wrote:
>> +struct emac_tx_ts_response_sr1 {
>> +	u32 lo_ts;
>> +	u32 hi_ts;
>> +	u32 reserved;
>> +	u32 cookie;
>> +};
> 
> In patch 10, this comes from skb->data, so seems to be a packet. Is the
> data dependent on the host endian, or is it always little endian?

Since prueth_rx_mgm_rsp_thread() in patch 10 calls le32_to_cpu() on the data
it gets from skb->data it seems likely that here the data is also __le32 and
these calls should also be added so that we can use u32 data types. I will
add these calls for next version unless there is some insight here that I am
missing.

Best regards,
Diogo