netdev - Re: [PATCH net-next 2/2] net: usbnet: Remove generic .ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b836152b-72a6-4815-a4d0-ee4956331a8d@suse.com>
Date: Wed, 6 Mar 2024 18:21:50 +0100
From: Oliver Neukum <oneukum@...e.com>
To: Breno Leitao <leitao@...ian.org>, Oliver Neukum <oneukum@...e.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, horms@...nel.org,
 dsahern@...nel.org,
 "open list:USB NETWORKING DRIVERS" <linux-usb@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: usbnet: Remove generic .ndo_get_stats64

On 06.03.24 15:26, Breno Leitao wrote:
> Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is
> configured") moved the callback to dev_get_tstats64() to net core, so,
> unless the driver is doing some custom stats collection, it does not
> need to set .ndo_get_stats64.
> 
> Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
> doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
> function pointer.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>
Acked-by: Oliver Neukum <oneukum@...e.com>