netdev - Re: [PATCH net-next v4 2/7] net: nexthop: Add NHA_OP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZeimRPbhmo4m012Z@shredder>
Date: Wed, 6 Mar 2024 19:22:12 +0200
From: Ido Schimmel <idosch@...dia.com>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, David Ahern <dsahern@...nel.org>,
	Simon Horman <horms@...nel.org>, mlxsw@...dia.com
Subject: Re: [PATCH net-next v4 2/7] net: nexthop: Add NHA_OP_FLAGS

On Wed, Mar 06, 2024 at 01:49:16PM +0100, Petr Machata wrote:
> In order to add per-nexthop statistics, but still not increase netlink
> message size for consumers that do not care about them, there needs to be a
> toggle through which the user indicates their desire to get the statistics.
> To that end, add a new attribute, NHA_OP_FLAGS. The idea is to be able to
> use the attribute for carrying of arbitrary operation-specific flags, i.e.
> not make it specific for get / dump.
> 
> Add the new attribute to get and dump policies, but do not actually allow
> any flags yet -- those will come later as the flags themselves are defined.
> Add the necessary parsing code.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: David Ahern <dsahern@...nel.org>

Reviewed-by: Ido Schimmel <idosch@...dia.com>