[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fc8a079f-10f1-4b2e-abc1-0a043eb1876e@gmail.com>
Date: Wed, 6 Mar 2024 09:42:02 -0800
From: Florian Fainelli <f.fainelli@...il.com>
To: Catalin Popescu <catalin.popescu@...ca-geosystems.com>,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, robh@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
kernel@...gutronix.de, festevam@...il.com, xiaoning.wang@....com,
linux-imx@....com, alexandre.torgue@...s.st.com, joabreu@...opsys.com,
mcoquelin.stm32@...il.com
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org, imx@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
bsp-development.geo@...ca-geosystems.com, m.felsch@...gutronix.de
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: dwmac-imx: add nxp,phy-wol
On 3/6/24 09:24, Catalin Popescu wrote:
> Add support for PHY WOL capability to dwmac-imx MAC driver.
>
> Signed-off-by: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
> ---
> Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> index 4c01cae7c93a..6cf373772eb1 100644
> --- a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> +++ b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> @@ -71,6 +71,12 @@ properties:
> description:
> To select RMII reference clock from external.
>
> + nxp,phy-wol:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + If present, indicates that PHY supports WOL(Wake-On-LAN), and PHY WOL will be enabled.
> + Otherwise, MAC WOL is preferred.
This is encoding a policy in Device Tree, which is not acceptable, see
my comment about your second patch.
pw-bot: cr
--
Florian
Powered by blists - more mailing lists