netdev - Re: [PATCH net-next] net: phy: dp8382x: keep WOL setting across suspends

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8de1d4e3-6d80-45a5-a638-48451d9b5c15@lunn.ch>
Date: Thu, 7 Mar 2024 00:04:50 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
Cc: hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	bsp-development.geo@...ca-geosystems.com, m.felsch@...gutronix.de
Subject: Re: [PATCH net-next] net: phy: dp8382x: keep WOL setting across
 suspends

On Wed, Mar 06, 2024 at 06:14:46PM +0100, Catalin Popescu wrote:
> Unlike other ethernet PHYs from TI, PHY dp83822x has WOL enabled
> at reset.

This is rather odd behaviour. Is this stated in the datasheet?

> @@ -572,11 +584,17 @@ static int dp83826_config_init(struct phy_device *phydev)
>  			return ret;
>  	}
>  
> +	if (dp83822->wol_enabled)
> +		return 0;
>  	return dp8382x_disable_wol(phydev);
>  }
>  
>  static int dp8382x_config_init(struct phy_device *phydev)
>  {
> +	struct dp83822_private *dp83822 = phydev->priv;
> +
> +	if (dp83822->wol_enabled)
> +		return 0;
>  	return dp8382x_disable_wol(phydev);

Since it is rather odd behaviour, there might be some BIOSes which
disable WoL. So i would not rely on it being enabled by
default. Explicitly enable it.

    Andrew

---
pw-bot: cr