netdev - Re: [PATCH net-next] net: phy: dp8382x: keep WOL setting across suspends

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b53818a7-66a4-4c7a-b687-efaea6cb9e4e@leica-geosystems.com>
Date: Thu, 7 Mar 2024 08:30:17 +0000
From: POPESCU Catalin <catalin.popescu@...ca-geosystems.com>
To: Andrew Lunn <andrew@...n.ch>
CC: "hkallweit1@...il.com" <hkallweit1@...il.com>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	GEO-CHHER-bsp-development <bsp-development.geo@...ca-geosystems.com>,
	"m.felsch@...gutronix.de" <m.felsch@...gutronix.de>
Subject: Re: [PATCH net-next] net: phy: dp8382x: keep WOL setting across
 suspends

On 07.03.24 00:04, Andrew Lunn wrote:
> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>
>
> On Wed, Mar 06, 2024 at 06:14:46PM +0100, Catalin Popescu wrote:
>> Unlike other ethernet PHYs from TI, PHY dp83822x has WOL enabled
>> at reset.
> This is rather odd behaviour. Is this stated in the datasheet?
Yes. I've checked all TI ethernet PHYs datasheets that are supported by 
linux and they all, but dp8382x, have WOL disabled by default. Hence, 
dp83822.c is the only driver that forcefully disable WOL at init.
>
>> @@ -572,11 +584,17 @@ static int dp83826_config_init(struct phy_device *phydev)
>>                        return ret;
>>        }
>>
>> +     if (dp83822->wol_enabled)
>> +             return 0;
>>        return dp8382x_disable_wol(phydev);
>>   }
>>
>>   static int dp8382x_config_init(struct phy_device *phydev)
>>   {
>> +     struct dp83822_private *dp83822 = phydev->priv;
>> +
>> +     if (dp83822->wol_enabled)
>> +             return 0;
>>        return dp8382x_disable_wol(phydev);
> Since it is rather odd behaviour, there might be some BIOSes which
> disable WoL. So i would not rely on it being enabled by
> default. Explicitly enable it.
I see, I'll make the change.
>
>      Andrew
>
> ---
> pw-bot: cr