netdev - Re: [PATCH net-next v3 05/12] net: ethernet: oa_tc6: implement error interrupts unmasking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f824a6f-a075-405f-b615-75076061a284@microchip.com>
Date: Thu, 7 Mar 2024 08:28:59 +0000
From: <Parthiban.Veerasooran@...rochip.com>
To: <andrew@...n.ch>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <horms@...nel.org>, <saeedm@...dia.com>,
	<anthony.l.nguyen@...el.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <corbet@....net>,
	<linux-doc@...r.kernel.org>, <robh+dt@...nel.org>,
	<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
	<devicetree@...r.kernel.org>, <Horatiu.Vultur@...rochip.com>,
	<ruanjinjie@...wei.com>, <Steen.Hegelund@...rochip.com>,
	<vladimir.oltean@....com>, <UNGLinuxDriver@...rochip.com>,
	<Thorsten.Kummermehr@...rochip.com>, <Pier.Beruto@...emi.com>,
	<Selvamani.Rajagopal@...emi.com>, <Nicolas.Ferre@...rochip.com>,
	<benjamin.bigler@...nformulastudent.ch>
Subject: Re: [PATCH net-next v3 05/12] net: ethernet: oa_tc6: implement error
 interrupts unmasking

Hi Andrew,

On 07/03/24 6:13 am, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Wed, Mar 06, 2024 at 02:20:10PM +0530, Parthiban Veerasooran wrote:
>> This will unmask the following error interrupts from the MAC-PHY.
>>    tx protocol error
>>    rx buffer overflow error
>>    loss of frame error
> 
> The standard seems to call it "Loss of framing". To me as a network
> person, a frame is an L2 Ethernet packet. However, framing is
> something completely different, being able to synchronise a bitstream
> with some sort of markers, e.g. E1 to know where the 32 slots are.
> 
> In this context, we are not talking about packets, but the SPI bit
> stream. So it would be good to use framing, not frame.
Yes you are right. The specification also says the same thing as you 
said "Loss of Framing Error". I will correct it in the next version.

Best regards,
Parthiban V
> 
>          Andrew
>