netdev - RE: [PATCH net 6/8] net: hns3: fix reset timeout under full functions and queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <BY3PR18MB4737FA1796C8BC8180296BE8C6202@BY3PR18MB4737.namprd18.prod.outlook.com>
Date: Thu, 7 Mar 2024 11:24:09 +0000
From: Sunil Kovvuri Goutham <sgoutham@...vell.com>
To: Jijie Shao <shaojijie@...wei.com>,
        "yisen.zhuang@...wei.com"
	<yisen.zhuang@...wei.com>,
        "salil.mehta@...wei.com" <salil.mehta@...wei.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>
CC: "shenjian15@...wei.com" <shenjian15@...wei.com>,
        "wangjie125@...wei.com"
	<wangjie125@...wei.com>,
        "liuyonglong@...wei.com" <liuyonglong@...wei.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE:  [PATCH net 6/8] net: hns3: fix reset timeout under full
 functions and queues



> -----Original Message-----
> From: Jijie Shao <shaojijie@...wei.com>
> Sent: Thursday, March 7, 2024 6:31 AM
> To: yisen.zhuang@...wei.com; salil.mehta@...wei.com;
> davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com
> Cc: shenjian15@...wei.com; wangjie125@...wei.com;
> liuyonglong@...wei.com; shaojijie@...wei.com; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org
> Subject: [EXTERNAL] [PATCH net 6/8] net: hns3: fix reset timeout under full
> functions and queues
> 
> From: Peiyang Wang <wangpeiyang1@...wei.com>
> 
> The cmdq reset command times out when all VFs are enabled and the
> queue is full. The hardware processing time exceeds the timeout set by the
> driver.
> In order to avoid the above extreme situations, the driver extends the reset
> timeout to 1 second.
> 

Reviewed-by: Sunil Goutham <sgoutham@...vell.com>

But one observation, loop of udelay(1) for 1sec seems a lot, probably better to use usleep_range().