netdev - Re: [PATCH net 6/8] net: hns3: fix reset timeout under full functions and queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <447cb805-9ad0-4e08-8038-45e3cb8c81fe@huawei.com>
Date: Fri, 8 Mar 2024 17:38:14 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Sunil Kovvuri Goutham <sgoutham@...vell.com>, "yisen.zhuang@...wei.com"
	<yisen.zhuang@...wei.com>, "salil.mehta@...wei.com" <salil.mehta@...wei.com>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>
CC: <shaojijie@...wei.com>, "shenjian15@...wei.com" <shenjian15@...wei.com>,
	"wangjie125@...wei.com" <wangjie125@...wei.com>, "liuyonglong@...wei.com"
	<liuyonglong@...wei.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net 6/8] net: hns3: fix reset timeout under full functions
 and queues


on 2024/3/7 19:24, Sunil Kovvuri Goutham wrote:
>> In order to avoid the above extreme situations, the driver extends the reset
>> timeout to 1 second.
>>
> Reviewed-by: Sunil Goutham <sgoutham@...vell.com>
>
> But one observation, loop of udelay(1) for 1sec seems a lot, probably better to use usleep_range().

but this is protected by splock, so cannot use usleep_range().