netdev - Re: [PATCH net] net: esp: fix bad handling of pages from page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240307095158.099d25ed@kernel.org>
Date: Thu, 7 Mar 2024 09:51:58 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Dragos Tatulea <dtatulea@...dia.com>
Cc: <almasrymina@...gle.com>, Steffen Klassert
 <steffen.klassert@...unet.com>, Herbert Xu <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 <leonro@...dia.com>, <gal@...dia.com>, "Anatoli N . Chechelnickiy"
 <Anatoli.Chechelnickiy@...nterpipe.biz>, Ian Kumlien
 <ian.kumlien@...il.com>, <stable@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: esp: fix bad handling of pages from page_pool

LGTM, thanks! Minor nit picks for the tags, otherise:

Reviewed-by: Jakub Kicinski <kuba@...nel.org>

On Thu, 7 Mar 2024 12:15:47 +0200 Dragos Tatulea wrote:
> Signed-off-by: Dragos Tatulea <dtatulea@...dia.com>

General guidance is to order tag chronologically, so:

Cc: stable@...r.kernel.org
Fixes: (speaking of which, you need to add it, presumably point it at
        the commit where skb->pp_recycle was added)
Reported-by:
Link / Closes:
your sign-off
Review tags

> Reported-by: Anatoli N.Chechelnickiy <Anatoli.Chechelnickiy@...nterpipe.biz>
> Tested-by: Anatoli N.Chechelnickiy <Anatoli.Chechelnickiy@...nterpipe.biz>

You can combine it as Reported-and-tested-by:
up to you

> Reported-by: Ian Kumlien <ian.kumlien@...il.com>
> Closes: https: //lore.kernel.org/netdev/CAA85sZvvHtrpTQRqdaOx6gd55zPAVsqMYk_Lwh4Md5knTq7AyA@...l.gmail.com

A space sneaked into the link.

> Cc: stable@...r.kernel.org
> Reviewed-by: Mina Almasry <almasrymina@...gle.com>
> Change-Id: I3d2744e1abb33a694a8f49e07f913724a0f8871a

Change-Id's gotta go.
-- 
pw-bot: cr