netdev - Re: [PATCH net] net: esp: fix bad handling of pages from page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a6f13f7cee46482bfcf6f889719f2007836c33f6.camel@nvidia.com>
Date: Thu, 7 Mar 2024 18:33:17 +0000
From: Dragos Tatulea <dtatulea@...dia.com>
To: "kuba@...nel.org" <kuba@...nel.org>
CC: "stable@...r.kernel.org" <stable@...r.kernel.org>, "davem@...emloft.net"
	<davem@...emloft.net>, "herbert@...dor.apana.org.au"
	<herbert@...dor.apana.org.au>, "dsahern@...nel.org" <dsahern@...nel.org>, Gal
 Pressman <gal@...dia.com>, "steffen.klassert@...unet.com"
	<steffen.klassert@...unet.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Leon Romanovsky <leonro@...dia.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "almasrymina@...gle.com" <almasrymina@...gle.com>,
	"Anatoli.Chechelnickiy@...nterpipe.biz"
	<Anatoli.Chechelnickiy@...nterpipe.biz>, "ian.kumlien@...il.com"
	<ian.kumlien@...il.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: esp: fix bad handling of pages from page_pool

On Thu, 2024-03-07 at 09:51 -0800, Jakub Kicinski wrote:
> LGTM, thanks! Minor nit picks for the tags, otherise:
> 
> Reviewed-by: Jakub Kicinski <kuba@...nel.org>
> 
Thanks!

> On Thu, 7 Mar 2024 12:15:47 +0200 Dragos Tatulea wrote:
> > Signed-off-by: Dragos Tatulea <dtatulea@...dia.com>
> 
> General guidance is to order tag chronologically, so:
> 
> Cc: stable@...r.kernel.org
> Fixes: (speaking of which, you need to add it, presumably point it at
>         the commit where skb->pp_recycle was added)
> Reported-by:
> Link / Closes:
> your sign-off
> Review tags
> 
> > Reported-by: Anatoli N.Chechelnickiy <Anatoli.Chechelnickiy@...nterpipe.biz>
> > Tested-by: Anatoli N.Chechelnickiy <Anatoli.Chechelnickiy@...nterpipe.biz>
> 
> You can combine it as Reported-and-tested-by:
> up to you
> 
> > Reported-by: Ian Kumlien <ian.kumlien@...il.com>
> > Closes: https: //lore.kernel.org/netdev/CAA85sZvvHtrpTQRqdaOx6gd55zPAVsqMYk_Lwh4Md5knTq7AyA@...l.gmail.com
> 
> A space sneaked into the link.
> 
> > Cc: stable@...r.kernel.org
> > Reviewed-by: Mina Almasry <almasrymina@...gle.com>
> > Change-Id: I3d2744e1abb33a694a8f49e07f913724a0f8871a
> 
> Change-Id's gotta go.
Fixed tags in v2. Thanks for explaining the tag order. It was never really clear
to me.

Thanks,
Dragos