[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240308144340.6d9c13cf@bootlin.com>
Date: Fri, 8 Mar 2024 14:43:40 +0100
From: Herve Codina <herve.codina@...tlin.com>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
<pabeni@...hat.com>, netdev@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH] net: wan: framer/pef2256: Convert to platform remove
callback returning void
Hi Uwe,
On Fri, 8 Mar 2024 09:51:09 +0100
Uwe Kleine-König <u.kleine-koenig@...gutronix.de> wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
Thanks for the patch.
Acked-by: Herve Codina <herve.codina@...tlin.com>
Regards,
Hervé
Powered by blists - more mailing lists