netdev - Re: [PATCH net-next 1/3] netlink: create a new header for internal genetlink symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240311113811.4b878ddb@kernel.org>
Date: Mon, 11 Mar 2024 11:38:11 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: David Wei <dw@...idwei.uk>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, jiri@...nulli.us, kuniyu@...zon.com
Subject: Re: [PATCH net-next 1/3] netlink: create a new header for internal
 genetlink symbols

On Sat, 9 Mar 2024 14:35:30 -0800 David Wei wrote:
> On 2024-03-09 10:34, Jakub Kicinski wrote:
> > There are things in linux/genetlink.h which are only used
> > under net/netlink/. Move them to a new local header.
> > A new header with just 2 externs isn't great, but alternative
> > would be to include af_netlink.h in genetlink.c which feels
> > even worse.  
> 
> Why is including af_netlink.h worse?

It exposes the internals of the lower layer of the protocol stack.
genetlink.c doesn't really need to know those details.