netdev - Re: [ovs-dev] [PATCH net-next 2/3] net: openvswitch: remove unnecessary linux/genetlink.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 18 Mar 2024 11:51:11 +0000
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, dev@...nvswitch.org, jiri@...nulli.us,
	netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com
Subject: Re: [ovs-dev] [PATCH net-next 2/3] net: openvswitch: remove
 unnecessary linux/genetlink.h include

On Sat, Mar 09, 2024 at 10:34:57AM -0800, Jakub Kicinski wrote:
> The only legit reason I could think of for net/genetlink.h
> and linux/genetlink.h to be separate would be if one was
> included by other headers and we wanted to keep it lightweight.
> That is not the case, net/openvswitch/meter.h includes
> linux/genetlink.h but for no apparent reason (for struct genl_family
> perhaps? it's not necessary, types of externs do not need
> to be known).
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Simon Horman <horms@...nel.org>