netdev - Re: [PATCH xfrm] xfrm: Allow UDP encapsulation only in offload modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37a7a9fb76f295cf8babb8251dea0033add4c40b.camel@redhat.com>
Date: Tue, 12 Mar 2024 13:24:31 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Leon Romanovsky <leon@...nel.org>, Steffen Klassert
	 <steffen.klassert@...unet.com>
Cc: Leon Romanovsky <leonro@...dia.com>, "David S. Miller"
 <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>, Herbert Xu
 <herbert@...dor.apana.org.au>, Jakub Kicinski <kuba@...nel.org>, 
 netdev@...r.kernel.org
Subject: Re: [PATCH xfrm] xfrm: Allow UDP encapsulation only in offload modes

On Tue, 2024-03-12 at 13:55 +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@...dia.com>
> 
> The missing check of x->encap caused to the situation where GSO packets
> were created with UDP encapsulation.
> 
> As a solution return the encap check for non-offloaded SA.
> 
> Fixes: 9f2b55961a80 ("xfrm: Pass UDP encapsulation in TX packet offload")

Should be:

Fixes: 983a73da1f99 ("xfrm: Pass UDP encapsulation in TX packet offload")

@Steffen: I guess you want to apply it first in your tree and send it later as PR?
In such case, could you please adjust the fixes hash while at it?

Thanks!

Paolo