netdev - Re: [net-next] dt-bindings: net: renesas,ethertsn: Create child-node for MDIO bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <171025363190.2187356.2945804003837370493.robh@kernel.org>
Date: Tue, 12 Mar 2024 08:27:14 -0600
From: Rob Herring <robh@...nel.org>
To: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
Cc: Paolo Abeni <pabeni@...hat.com>, linux-renesas-soc@...r.kernel.org,
	devicetree@...r.kernel.org, Sergey Shtylyov <s.shtylyov@....ru>,
	Conor Dooley <conor+dt@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [net-next] dt-bindings: net: renesas,ethertsn: Create child-node
 for MDIO bus


On Mon, 11 Mar 2024 15:35:07 +0100, Niklas Söderlund wrote:
> The design for this driver followed that of other Renesas Ethernet
> drivers and thus did not force a child-node for the MDIO bus. As there
> are no upstream drivers or users of this binding yet take the
> opportunity to correct this and force the usage of a child-node for the
> MDIO bus.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
> ---
> Hello,
> 
> Learn from the mistake made with the Renesas AVB bindings being worked
> on in [1] where no mdio node was used to describe the MDIO bus and the
> PHY was added directly as a child node to the AVB node.
> 
> The Ethernet TSN driver is still in review and have not been merged and
> no usage of the bindings merged either. So while this breaks the binding
> it effects no one so we can correct this mistake without breaking any
> use-cases before we need to support any backward compatibility.
> 
> 1. https://patchwork.kernel.org/project/netdevbpf/list/?series=834331
> ---
>  .../bindings/net/renesas,ethertsn.yaml        | 33 ++++++++-----------
>  1 file changed, 14 insertions(+), 19 deletions(-)
> 

Reviewed-by: Rob Herring <robh@...nel.org>