netdev - Re: [PATCH net-next v1] netdevsim: replace pr_err with {dev,netdev,}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7b1abd98-ee3c-416a-b929-ed4cc9d646b1@davidwei.uk>
Date: Tue, 12 Mar 2024 15:04:59 -0700
From: David Wei <dw@...idwei.uk>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v1] netdevsim: replace pr_err with
 {dev,netdev,}_err wherever possible

On 2024-03-11 13:07, Jakub Kicinski wrote:
> On Sat,  9 Mar 2024 17:52:15 -0800 David Wei wrote:
>> -		pr_err("Failed to get snapshot id\n");
>> +		dev_err(&nsim_dev->nsim_bus_dev->dev, "Failed to get snapshot id\n");
> 
> We seem to use dev_err(&nsim_dev->nsim_bus_dev->dev, ...
> in quite a few places after this patch, how about we add a wrapper
> 
> #define nsim_err(ns_dev, args...) \
> 	dev_err(&(ns_dev)->nsim_bus_dev->dev(dev), ##args)
> ?

Yeah SG, I'll define it in netdevsim.h.

I'll re-send once net-next is open again.