netdev - Re: [net-next,v3 2/2] ravb: Add support for an optional MDIO mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fc6b2bc7-cdd8-4b9a-a698-618cf144e387@lunn.ch>
Date: Tue, 12 Mar 2024 23:05:35 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
Cc: Sergey Shtylyov <s.shtylyov@....ru>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Biju Das <biju.das.jz@...renesas.com>, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [net-next,v3 2/2] ravb: Add support for an optional MDIO mode

On Mon, Mar 11, 2024 at 03:11:06PM +0100, Niklas Söderlund wrote:
> The driver used the DT node of the device itself when registering the
> MDIO bus. While this works, it creates a problem: it forces any MDIO bus
> properties to also be set on the devices DT node. This mixes the
> properties of two distinctly different things and is confusing.
> 
> This change adds support for an optional mdio node to be defined as a
> child to the device DT node. The child node can then be used to describe
> MDIO bus properties that the MDIO core can act on when registering the
> bus.
> 
> If no mdio child node is found the driver fallback to the old behavior
> and register the MDIO bus using the device DT node. This change is
> backward compatible with old bindings in use.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew