netdev - Re: [Intel-wired-lan] [PATCH iwl-net v2] i40e: fix vf may be used uninitialized in this function warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec459f09-6355-439f-bb1b-4320cb149ea7@molgen.mpg.de>
Date: Wed, 13 Mar 2024 13:39:10 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org,
 Anthony L Nguyen <anthony.l.nguyen@...el.com>, netdev@...r.kernel.org,
 Przemyslaw Kitszel <przemyslaw.kitszel@...el.com>,
 Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] i40e: fix vf may be used
 uninitialized in this function warning


Dear Aleksandr,


Thank you for your reply.

Am 13.03.24 um 13:34 schrieb Loktionov, Aleksandr:

>> -----Original Message-----
>> From: Paul Menzel <pmenzel@...gen.mpg.de>
>> Sent: Wednesday, March 13, 2024 11:58 AM

>> Am 13.03.24 um 10:56 schrieb Aleksandr Loktionov:
>>> To fix the regression introduced by commit 52424f974bc5, which causes
>>> servers hang in very hard to reproduce conditions with resets races.
>>> Using two sources for the information is the root cause.
>>> In this function before the fix bumping v didn't mean bumping vf
>>> pointer. But the code used this variables interchangeably, so staled
>>> vf could point to different/not intended vf.
>>>
>>> Remove redundant "v" variable and iterate via single VF pointer across
>>> whole function instead to guarantee VF pointer validity.
>>>
>>> Fixes: 52424f974bc5 ("i40e: Fix VF hang when reset is triggered on another VF")
>>> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
>>> Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>
>>> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>>> ---
>>> v1 -> v2: commit message change
>>
>> Thank you very much. No need to resend, but I find it also always
>> useful to have the exact warning pasted in the commit message.
>>
> The warning is exactly "vf may be used uninitialized in this
> function"  it's already in the title. What you suggest me to do?
Doesn’t the warning also contain the line number? I’d paste the wohle 
line – as there is also no problem in having some information of the 
summary/title duplicated in the message. Anyway, as written, not important.


Kind regards,

Paul