netdev - RE: [Intel-wired-lan] [PATCH iwl-net v2] i40e: fix vf may be used uninitialized in this function warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR11MB588064233A6D761E9ED93E1D8F362@PH0PR11MB5880.namprd11.prod.outlook.com>
Date: Mon, 25 Mar 2024 10:58:14 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>, Paul Menzel
	<pmenzel@...gen.mpg.de>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Kubalewski, Arkadiusz"
	<arkadiusz.kubalewski@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v2] i40e: fix vf may be used
 uninitialized in this function warning



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Loktionov, Aleksandr
> Sent: Wednesday, March 13, 2024 1:35 PM
> To: Paul Menzel <pmenzel@...gen.mpg.de>
> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kubalewski, Arkadiusz
> <arkadiusz.kubalewski@...el.com>; intel-wired-lan@...ts.osuosl.org; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>; netdev@...r.kernel.org
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] i40e: fix vf may be used
> uninitialized in this function warning
> 
> 
> 
> > -----Original Message-----
> > From: Paul Menzel <pmenzel@...gen.mpg.de>
> > Sent: Wednesday, March 13, 2024 11:58 AM
> > To: Loktionov, Aleksandr <aleksandr.loktionov@...el.com>
> > Cc: intel-wired-lan@...ts.osuosl.org; Nguyen, Anthony L
> > <anthony.l.nguyen@...el.com>; netdev@...r.kernel.org; Kitszel,
> > Przemyslaw <przemyslaw.kitszel@...el.com>; Kubalewski, Arkadiusz
> > <arkadiusz.kubalewski@...el.com>
> > Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] i40e: fix vf may be
> > used uninitialized in this function warning
> >
> > Dear Aleksandr,
> >
> >
> > Am 13.03.24 um 10:56 schrieb Aleksandr Loktionov:
> > > To fix the regression introduced by commit 52424f974bc5, which
> > causes
> > > servers hang in very hard to reproduce conditions with resets
> > races.
> > > Using two sources for the information is the root cause.
> > > In this function before the fix bumping v didn't mean bumping vf
> > > pointer. But the code used this variables interchangeably, so
> > staled
> > > vf could point to different/not intended vf.
> > >
> > > Remove redundant "v" variable and iterate via single VF pointer
> > across
> > > whole function instead to guarantee VF pointer validity.
> > >
> > > Fixes: 52424f974bc5 ("i40e: Fix VF hang when reset is triggered
> > on
> > > another VF")
> > > Signed-off-by: Aleksandr Loktionov
> > <aleksandr.loktionov@...el.com>
> > > Reviewed-by: Arkadiusz Kubalewski
> > <arkadiusz.kubalewski@...el.com>
> > > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> > > ---
> > > v1 -> v2: commit message change
> >
> > Thank you very much. No need to resend, but I find it also always
> > useful to have the exact warning pasted in the commit message.
> >
> The warning is exactly "vf may be used uninitialized in this function"  it's
> already in the title. What you suggest me to do?
> Thank you
> 
> > […]
> >
> > > ---
> > >   .../ethernet/intel/i40e/i40e_virtchnl_pf.c    | 34 +++++++++---
> > -------
> > >   1 file changed, 16 insertions(+), 18 deletions(-)
> >
> > Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
> >
> >
> > Kind regards,
> >
> > Paul

Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>