netdev - Re: [PATCH net v2] hsr: Handle failures in module init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240318.142334.2245574100586239129.syoshida@redhat.com>
Date: Mon, 18 Mar 2024 14:23:34 +0900 (JST)
From: Shigeru Yoshida <syoshida@...hat.com>
To: fmaurer@...hat.com
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, leitao@...ian.org, dkirjanov@...e.de
Subject: Re: [PATCH net v2] hsr: Handle failures in module init

On Fri, 15 Mar 2024 13:04:52 +0100, Felix Maurer wrote:
> A failure during registration of the netdev notifier was not handled at
> all. A failure during netlink initialization did not unregister the netdev
> notifier.
> 
> Handle failures of netdev notifier registration and netlink initialization.
> Both functions should only return negative values on failure and thereby
> lead to the hsr module not being loaded.
> 
> Fixes: f421436a591d ("net/hsr: Add support for the High-availability Seamless Redundancy protocol (HSRv0)")
> Signed-off-by: Felix Maurer <fmaurer@...hat.com>

The patch LGTM. Module initialization errors are handled
correctly. Netdev notifier is correctly unregistered when netlink
initialization fails.

Reviewed-by: Shigeru Yoshida <syoshida@...hat.com>

> ---
>  net/hsr/hsr_main.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/net/hsr/hsr_main.c b/net/hsr/hsr_main.c
> index cb83c8feb746..9756e657bab9 100644
> --- a/net/hsr/hsr_main.c
> +++ b/net/hsr/hsr_main.c
> @@ -148,14 +148,21 @@ static struct notifier_block hsr_nb = {
>  
>  static int __init hsr_init(void)
>  {
> -	int res;
> +	int err;
>  
>  	BUILD_BUG_ON(sizeof(struct hsr_tag) != HSR_HLEN);
>  
> -	register_netdevice_notifier(&hsr_nb);
> -	res = hsr_netlink_init();
> +	err = register_netdevice_notifier(&hsr_nb);
> +	if (err)
> +		return err;
> +
> +	err = hsr_netlink_init();
> +	if (err) {
> +		unregister_netdevice_notifier(&hsr_nb);
> +		return err;
> +	}
>  
> -	return res;
> +	return 0;
>  }
>  
>  static void __exit hsr_exit(void)
> -- 
> 2.44.0
> 
>