netdev - Re: [GIT PULL] virtio: features, fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wi363CLXBm=jB=eAtJQ18E-h4Vwrgmd6_7Q=DN+9u8z6w@mail.gmail.com>
Date: Tue, 19 Mar 2024 11:03:44 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: kvm@...r.kernel.org, virtualization@...ts.linux-foundation.org, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	alex.williamson@...hat.com, andrew@...nix.com, david@...hat.com, 
	dtatulea@...dia.com, eperezma@...hat.com, feliu@...dia.com, 
	gregkh@...uxfoundation.org, jasowang@...hat.com, jean-philippe@...aro.org, 
	jonah.palmer@...cle.com, leiyang@...hat.com, lingshan.zhu@...el.com, 
	maxime.coquelin@...hat.com, ricardo@...liere.net, shannon.nelson@....com, 
	stable@...nel.org, steven.sistare@...cle.com, suzuki.poulose@....com, 
	xuanzhuo@...ux.alibaba.com, yishaih@...dia.com
Subject: Re: [GIT PULL] virtio: features, fixes

On Tue, 19 Mar 2024 at 00:41, Michael S. Tsirkin <mst@...hat.com> wrote:
>
> virtio: features, fixes
>
> Per vq sizes in vdpa.
> Info query for block devices support in vdpa.
> DMA sync callbacks in vduse.
>
> Fixes, cleanups.

Grr. I thought the merge message was a bit too terse, but I let it slide.

But only after pushing it out do I notice that not only was the pull
request message overly terse, you had also rebased this all just
moments before sending the pull request and didn't even give a hit of
a reason for that.

So I missed that, and the merge is out now, but this was NOT OK.

Yes, rebasing happens. But last-minute rebasing needs to be explained,
not some kind of nasty surprise after-the-fact.

And that pull request explanation was really borderline even *without*
that issue.

                Linus