[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240319124317.3c3f16cd@kernel.org>
Date: Tue, 19 Mar 2024 12:43:17 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Maciej Fijalkowski <maciej.fijalkowski@...el.com>, Jesse Brandeburg
<jesse.brandeburg@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet
<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Przemek Kitszel
<przemyslaw.kitszel@...el.com>, intel-wired-lan@...ts.osuosl.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] ice: Fix freeing uninitialized pointers
On Sat, 16 Mar 2024 12:44:40 +0300 Dan Carpenter wrote:
> - struct ice_aqc_get_phy_caps_data *pcaps __free(kfree);
> - void *mac_buf __free(kfree);
> + struct ice_aqc_get_phy_caps_data *pcaps __free(kfree) = NULL;
> + void *mac_buf __free(kfree) = NULL;
This is just trading one kind of bug for another, and the __free()
magic is at a cost of readability.
I think we should ban the use of __free() in all of networking,
until / unless it cleanly handles the NULL init case.
Powered by blists - more mailing lists