netdev - Re: [PATCH net-next v4 3/8] virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1710922342.4241717-2-xuanzhuo@linux.alibaba.com>
Date: Wed, 20 Mar 2024 16:12:22 +0800
From: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>,
 Eric   Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>,
 "Michael S.   Tsirkin" <mst@...hat.com>,
 Jason Wang <jasowang@...hat.com>,
 Alexei   Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 Stanislav Fomichev <sdf@...gle.com>,
 Amritha   Nambiar <amritha.nambiar@...el.com>,
 Larysa Zaremba <larysa.zaremba@...el.com>,
 Sridhar Samudrala <sridhar.samudrala@...el.com>,
 Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
 virtualization@...ts.linux.dev,
 bpf@...r.kernel.org
Subject: Re: [PATCH net-next v4 3/8] virtio_net: support device stats

On Tue, 19 Mar 2024 10:15:25 -0700, Jakub Kicinski <kuba@...nel.org> wrote:
> On Fri, 15 Mar 2024 16:05:40 +0800 Xuan Zhuo wrote:
> > > Don't duplicate the stats which get reported via the netlink API in
> > > ethtool. Similar story to the rtnl stats:
> > >
> > > https://docs.kernel.org/next/networking/statistics.html#notes-for-driver-authors
> >
> > Sorry, this patch set did not follow this.
> >
> > I will fix in next version.
> >
> > But I plan that will be done in the commit "virtio-net: support queue stat".
> > This commit in next version will report all stat by ethtool -S.
> > The commit "virtio-net: support queue stat" in next version
> > will not report the duplicate the stats that reported via the netlink API.
> >
> > Do you think ok?
>
> I guess that could save time refactoring the code, but we generally
> push authors to go the extra mile and make reviewers life easier.
> Also, in a way, making the evolution of the code base look more
> logical. So I'd prefer if the series was reorganized to never
> expose the standard stats via -S.

v5 was post.

I will try in v6.

Thanks.